Separate out precommit configuration #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for veda-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
great catch! 🧠 |
stephenkilbourn
approved these changes
Jan 22, 2024
1 task
sandrahoang686
added a commit
that referenced
this pull request
Feb 13, 2024
https://github.com/NASA-IMPACT/veda-ui/releases/tag/v4.1.0 ## 🎉 Features - Experimental CMR Layer: #805 ## 🚀 Improvements - Style - Documentation - Rename critical error page: #806 - Add back button on Exploration page: #779 - Add ts, lint check for precommit hooks: #788, #809 - "skip to main" button for navigation: #808 ## 🐛 Fixes - Return datasets even when there is a dataset without summaries: #786 - Show all the datasets on Data Catalog page: #837 - Block Map user defined position fix: #784 - Geocoder centering on various projecctions: #826
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem (ts check does not scope the type check to the staged files. ex. throwing module not found error if the module is imported in a staged file, but not added to the stage) of ts-check in precommit hook by following: lint-staged/lint-staged#825 (comment)